Re: [Alsa-devel] Re: + v4l-720-alsa-support-for-saa7134-that-should-work-fix.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Takashi Iwai <[email protected]> wrote:
>
> > OK, a brief review:
>  > 
>  >  - Why couldn't you use ALSA's DMA API?
> 
>  This is OK, IMO.  Basically, it's up to the driver.
> 
> 
>  >  - The DMA must be stopped and started in the trigger callback, not the
>  > prepare callback.
>  > 
>  >  - If this device lacks a volume control alsa-lib can emulate it in
>  > software, just create a proper /usr/share/alsa/cards/your_card.conf
>  > file.
>  > 
>  >  - By ALSA convention the acceptable formats, sample rates, etc should
>  > be directly defined in the snd_pcm_hardware_t structure.
>  > 
>  >  - dev->oss needs to go.
> 
>  Agreed about the rest.

Thanks, guys.

Despite all that, I am inclined to merge this patch into 2.6.15.  Because
it's in the middle of a 192-patch series and we do need to get the v4l tree
synced up.

Mauro&co, if we do that, do you think the above points can be addressed
inside the next four weeks or so?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux