Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx

On Mon, Nov 07, 2005 at 09:53:25AM +0200, Pantelis Antoniou wrote:
> John W. Linville wrote:

> >@@ -1,6 +1,6 @@
> > config FEC_8XX
> > 	tristate "Motorola 8xx FEC driver"
> >-	depends on NET_ETHERNET
> >+	depends on NET_ETHERNET && 8xx
> > 	select MII
> > 
> > config FEC_8XX_GENERIC_PHY
> 
> Yes, this is the correct approach. Please disregard the other
> patches floating about.

Pretty sure you are right.  However, a broken version already got
committed.  It added FEC as a dependency.  That keeps it from breaking
everyone else, but it make the driver available for Coldfire rather
than for PPC 8xx...

I'll reform that patch and repost.

John
-- 
John W. Linville
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [patch 2.6.14 (take #2)] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
    • From: "John W. Linville" <[email protected]>

• References:
  • [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
    • From: "John W. Linville" <[email protected]>
  • Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
    • From: Pantelis Antoniou <[email protected]>

• Prev by Date: Re: 3D video card recommendations
• Next by Date: [patch 2.6.14 (take #2)] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
• Previous by thread: Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
• Next by thread: [patch 2.6.14 (take #2)] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]