Re: [PATCH] kbuild updates

[Roman Zippel <zippel@linux-m68k.org>]

Hi,

On Sun, 6 Nov 2005, Sam Ravnborg wrote:

> On Sun, Nov 06, 2005 at 01:44:32PM +0100, Roman Zippel wrote:
> > 
> > What exactly is the problem? How does Fedora use QTLIB?
> 
> See:
>  https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=137926

I'm not really happy with this patch. I don't really like relying on 
QTLIB, it's a really ugly hack.
If the nonextisting ../lib64 dir is the problem, I'd more prefer a patch 
like this:

Index: linux-2.6/scripts/kconfig/Makefile
===================================================================
--- linux-2.6.orig/scripts/kconfig/Makefile	2005-11-06 00:27:29.000000000 +0100
+++ linux-2.6/scripts/kconfig/Makefile	2005-11-07 11:08:58.000000000 +0100
@@ -162,9 +164,10 @@ $(obj)/.tmp_qtcheck:
 	  echo "*"; \
 	  false; \
 	fi; \
-	LIBPATH=$$DIR/lib; LIB=qt; \
+	LIBPATH=$$DIR/lib; LIB=qt; osdir=""; \
 	$(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
-	  LIBPATH=$$DIR/lib/$$($(HOSTCXX) -print-multi-os-directory); \
+	  osdir=$$($(HOSTCXX) -print-multi-os-directory); \
+	if [ -d $$LIBPATH/$$osdir ]; then LIBPATH=$$LIBPATH/$$osdir; fi; \
 	if [ -f $$LIBPATH/libqt-mt.so ]; then LIB=qt-mt; fi; \
 	echo "QTDIR=$$DIR" > $@; echo "QTLIBPATH=$$LIBPATH" >> $@; \
 	echo "QTLIB=$$LIB" >> $@; \

Does this also solve the problem?

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/