Re: [PATCH] hfsplus: don't modify journaled volume

[Anton Altaparmakov <aia21@cam.ac.uk>]

On Sat, 5 Nov 2005, Roman Zippel wrote:
> On Sat, 5 Nov 2005, Anton Altaparmakov wrote:
> > > I would agree with that and further, is that not a bit draconian?  
> > > HFSPlus is designed to work without the journal.  Just change the last 
> > > mounted version to FSK! (0x46534b21) and everything will work as expected, 
> > > i.e. fsck will run a check instead of ignoring the volume and osx will 
> > > mount the volume and reinitialize the journal.  Remember older OSX 
> > > versions did not support journalling so if you attached your external 
> > > drive to one of those older osx boxes, you would also get non-journalled 
> > > writes to a journalled volume.  It's all designed for it...
> > 
> > And you do not need to be worried about journal reply because you 
> > already do not allow read/write mounts when the volume has not been 
> > unmounted cleanly, so there really is no reason not to allow mounting 
> > a volume with a journal...
> 
> Sorry, but I had too many reports about problems with journaled volumes, 
> so I prefer the safe solution, until we can at least replay the journal.

Yes but that would be because you leave an active journal and do changes 
behind its back without telling the OSX HFSPlus driver that you have done 
changes behind its back...  My suggestion was to tell the driver that you 
have done changes behind its back so it will be happy.

Anyway, you are the maintainer, you decide.  I was only highlighting how 
you could do it safely.

I compile my own kernels so I can always edit your patch out (I happen to 
want to write to journalled hfs+ volumes)...

Best regards,

	Anton
-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/