Re: [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c

On Sat, 2005-11-05 at 17:27 +0100, Arnd Bergmann wrote:
> plain text document attachment (sg-ioctl.diff)
> The sg driver already has a compat_ioctl function, so the
> conversion handler for SG_IO can easily be moved in there
> as well. It still uses compat_alloc_user_space, so it can
> probably be simplified by using merging the conversion
> handler with the native method.

This is the wrong place, isn't it?  SG_IO is also in
drivers/block/scsi_ioctl.c which isn't modular, so shouldn't this be in
there?

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c
    • From: Arnd Bergmann <[email protected]>

• References:
  • [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c
    • From: Arnd Bergmann <[email protected]>

• Prev by Date: Re: [PATCH 01/25] compat: Remove leftovers from register_ioctl32_conversion
• Next by Date: Re: [PATCH 01/25] compat: Remove leftovers from register_ioctl32_conversion
• Previous by thread: [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c
• Next by thread: Re: [PATCH 12/25] scsi: move SG_IO ioctl32 code to sg.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]