Re: [WATCHDOG] sa1100_wdt.c sparse cleanups

On Sat, Nov 05, 2005 at 10:10:27AM +0000, Russell King wrote:
> It's probably better to use a union with these, eg:
> 
> 	union {
> 		void __user *arg;
> 		struct watchdog_info __user *info;
> 		int __user *i;
> 	} u;
> 
> 	u.arg = (void __user *)arg;
> 
> ...
> 
> 	ret = copy_to_user(u.info, &ident, sizeof(ident)) ? -EFAULT : 0;

Just use void __user *.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [WATCHDOG] sa1100_wdt.c sparse cleanups
    • From: Russell King <[email protected]>

• References:
  • [WATCHDOG] sa1100_wdt.c sparse cleanups
    • From: Ian Campbell <[email protected]>
  • Re: [WATCHDOG] sa1100_wdt.c sparse cleanups
    • From: Russell King <[email protected]>

• Prev by Date: Re: New Linux Development Model
• Next by Date: Re: New Linux Development Model
• Previous by thread: Re: [WATCHDOG] sa1100_wdt.c sparse cleanups
• Next by thread: Re: [WATCHDOG] sa1100_wdt.c sparse cleanups
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]