Christoph Hellwig <[email protected]> wrote:
>
> On Fri, Nov 04, 2005 at 02:55:34PM -0800, Andrew Morton wrote:
> > > Can we please move dma_get_cache_alignment() out of line instead?
> >
> > It's a single statement! It wants to be inlined.
> >
> > > Always export sane APIs instead of random internals.
> >
> > The exported API is dma_get_cache_alignment(). For internal implementation
> > reasons we need to export an ia64 symbol to modules to support it. That
> > kinda sucks, but I don't think that we need to compromise kernel size and
> > performance because of it.
>
> It's an API used only in slow pathes. It's much better to enforce modularity
> in that case.
hm, spose so. Putting it into .c means that all arches except one
implement it under include/, which is also a bit irritating sometimes, such
as $EDITOR include/asm-*/dma-mapping.h.
It's a 51%/49% decision, but I'm not sure which way.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
