On Wed, Nov 02, 2005 at 08:49:29PM -0700, Phillip Hellewell wrote:
> +#ifdef HAVE_CONFIG_H
> +# include <config.h>
> +#endif /* HAVE_CONFIG_H */
What is this here for?
> +#include <net/sock.h>
> +#include <linux/file.h>
net/ after linux/ please. Why do you need sock.h anyway?
> +/**
> + * Module parameter that defines the ecryptfs_verbosity level.
> + */
> +#define VERBOSE_DUMP 9
> +#ifdef DEBUG
> +int ecryptfs_verbosity = VERBOSE_DUMP;
> +#else
> +int ecryptfs_verbosity = 1;
> +#endif
> +module_param(ecryptfs_verbosity, int, 1);
I don't think you want a "1" here, do you? Hint, it's not doing what
you think it is doing...
> +void __ecryptfs_kfree(void *ptr, const char *fun, int line)
> +{
> + if (unlikely(ECRYPTFS_ENABLE_MEMORY_TRACING))
> + ecryptfs_printk_release(ptr, fun, line);
> + kfree(ptr);
> +}
> +
> +void *__ecryptfs_kmalloc(size_t size, unsigned int flags, const char *fun,
> + int line)
<snip>
Don't have wrappers for all of the common kernel functions, just call
them directly.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
