Michael Krufky <[email protected]> wrote:
>
>
> From: Kirk Lapray <[email protected]>
>
> * nxt200x.c, nxt200x.h
> - New frontend module that supports both NXT2002 and NXT2004.
> So far, only tested on NXT2004. After testing on NXT2002, we should
> deprecate the nxt2002 module, and implement this one instead on the
> applicable cards.
>
> * get_dvb_firmware:
> - Added support for the NXT2004 firmware. This firmware works with both
> the ATI HDTV Wonder and the AVerTVHD MCE a180.
> This was originally written by Jean-Francois Thibert
>
> * dvb-pll.c
> - Fixed minimum frequency for tuv1236d. It seems that the data sheets
> are wrong.
>
> ...
> +static int nxt200x_writebytes (struct nxt200x_state* state, u8 reg, u8 *buf, u8 len)
> +{
> + u8 buf2 [len+1];
hm, a variable-sized array, with the size defined by the caller. I guess as the size is
in a u8 it's unlikely to cause too much trouble.
(Wonders what the compiler will do if len==255. 256, I think.)
> +static int nxt200x_readreg_multibyte (struct nxt200x_state* state, u8 reg, u8* data, u8 len)
> +{
> + int i;
> + u8 buf, len2, attr;
> + dprintk("%s\n", __FUNCTION__);
> +
> + /* set mutli register register */
> + nxt200x_writebytes(state, 0x35, ®, 1);
> +
> + switch (state->demod_chip) {
> + case NXT2002:
> + /* set multi register length */
> + len2 = len & 0x80;
> + nxt200x_writebytes(state, 0x34, &len2, 1);
> +
> + /* read the actual data */
> + nxt200x_readbytes(state, reg, data, len);
> + return 0;
> + break;
> + case NXT2004:
> + /* probably not right, but gives correct values */
> + attr = 0x02;
> + if (reg & 0x80) {
> + attr = attr << 1;
> + if (reg & 0x04)
> + attr = attr >> 1;
> + }
> +
> + /* set multi register length */
> + len2 = (attr << 4) | len;
> + nxt200x_writebytes(state, 0x34, &len2, 1);
> +
> + /* toggle the multireg bit*/
> + buf = 0x80;
> + nxt200x_writebytes(state, 0x21, &buf, 1);
> +
> + /* read status */
> + nxt200x_readbytes(state, 0x21, &buf, 1);
> +
> + if (buf == 0)
> + {
> + /* read the actual data */
> + for(i = 0; i < len; i++) {
> + nxt200x_readbytes(state, 0x36 + i, &data[i], 1);
> + }
> + return 0;
whitespace broke.
> + }
> + break;
> + default:
> + return -EINVAL;
> + break;
> + }
We usually indent the body of a switch statement one tab further to the left.
> +
> +static int nxt200x_writetuner (struct nxt200x_state* state, u8* data)
> +{
> + u8 buf, count = 0;
> +
> + dprintk("%s\n", __FUNCTION__);
> +
> + dprintk("Tuner Bytes: %02X %02X %02X %02X\n", data[0], data[1], data[2], data[3]);
> +
> + /* if pll is a Philips TUV1236D then write directly to tuner */
> + if (strcmp(state->config->pll_desc->name, "Philips TUV1236D") == 0) {
Does DVB have a better way of identifying a device type than strcmp?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
