Re: [PATCH 2.6.13] airo.c: remove delay in airo_get_scan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bill Moss wrote:
Remove 3 second delay in airo_get_scan. Testing shows this delay is unnecessary. Users of NetworkManager
find this delay make NetworkManager slow to connect.

--- a/drivers/net/wireless/airo.c	2005-11-01 21:21:04.000000000 -0500
+++ b/drivers/net/wireless/airo.c	2005-11-01 21:22:41.000000000 -0500
@@ -6918,7 +6918,7 @@
 	/* When we are associated again, the scan has surely finished.
 	 * Just in case, let's make sure enough time has elapsed since
 	 * we started the scan. - Javier */
-	if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp+3*HZ)) {
+	if(ai->scan_timestamp && time_before(jiffies,ai->scan_timestamp)) {
 		/* Important note : we don't want to block the caller
 		 * until results are ready for various reasons.
 		 * First, managing wait queues is complex and racy

Signed-off-by: Bill Moss <[email protected]>

With this change, the time_before() test can't possibly succeed, can it? In that case, why not remove the if and its body completely?

Michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux