On Wed, Nov 02, 2005 at 02:42:12AM -0600, Hareesh Nagarajan wrote:
> If we have a look at the register_filesystem() function defined in
> fs/filesystems.c, we see that if a filesystem with a same name has
> already been registered then the find_filesystem() function will return
> NON-NULL otherwise it will return NULL.
>
> Hence, register_filesystem() should return EEXIST instead of EBUSY.
> Returning EBUSY is misleading (unless of course I'm missing something
> obvious) to the caller of register_filesystem().
This `slot' is buy, so EBUSY makes sense. Filesytem is not file, hence
EEXIST doesn't apply IMHO.
Coywolf
>
> Thanks,
>
> Hareesh Nagarajan
>
> --- linux-2.6.13.4/fs/filesystems.c 2005-10-10 13:54:29.000000000 -0500
> +++ linux-2.6.13.4-edit/fs/filesystems.c 2005-11-02 02:33:30.685600000 -0600
> @@ -76,7 +76,7 @@
> write_lock(&file_systems_lock);
> p = find_filesystem(fs->name);
> if (*p)
> - res = -EBUSY;
> + res = -EEXIST;
> else
> *p = fs;
> write_unlock(&file_systems_lock);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
