Re: [PATCH] Eagle and ADI 930 usb adsl modem driver

[Greg KH <greg@kroah.com>]

On Wed, Nov 02, 2005 at 08:54:22AM +0100, Duncan Sands wrote:
> > > + * sometime hotplug don't have time to give the firmware the
> > > + * first time, retry it.
> > > + */
> > > +static int sleepy_request_firmware(const struct firmware **fw, 
> > > +		const char *name, struct device *dev)
> > > +{
> > > +	if (request_firmware(fw, name, dev) == 0)
> > > +		return 0;
> > > +	msleep(1000);
> > > +	return request_firmware(fw, name, dev);
> > > +}
> > 
> > No, use the async firmware download mode instead of this.  That will
> > solve all of your problems.
> 
> Hi Greg, it looks like you understand what the problem is here.  Could
> you please explain to us lesser mortals ;)

If you use the async mode, there is no timeout.  When userspace gets
around to giving you the firmware, then you continue on with the rest of
your device initialization (don't block the usb probe function though.)

Everyone should switch to that interface, then we would not have any
timeout issues anymore...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/