Re: [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface

Christoph Lameter <[email protected]> wrote:
>
> ...
> Changes V3->V4:
> - Add Ray's permissions check based on check_kill_permission().
> 
> ...
> +	/*
> +	 * Permissions check like for signals.
> +	 * See check_kill_permission()
> +	 */
> +	if ((current->euid ^ task->suid) && (current->euid ^ task->uid) &&
> +	    (current->uid ^ task->suid) && (current->uid ^ task->uid) &&
> +	    !capable(CAP_SYS_ADMIN)) {
> +		err = -EPERM;
> +		goto out;
> +	}

Obscure.  Can you please explain the thinking behind putting this check in
here?  Preferably via a comment...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface
    • From: "linux-os \(Dick Johnson\)" <[email protected]>

• References:
  • [PATCH 0/5] Swap Migration V5: Overview
    • From: Christoph Lameter <[email protected]>
  • [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: PCI-DMA: high address but no IOMMU - nForce4
• Next by Date: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
• Previous by thread: [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface
• Next by thread: Re: [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]