Christoph> No. Bitfields for accessing hardware/wire
Christoph> datastructures are wrong and will always break in some
Christoph> circumstances. Your header is much better.
OK, that's my feeling as well.
Would it make sense for me to split the pure SRP spec structures and
so on into a separate file and put it in include/scsi/srp.h? Then we
can move ibmvscsi towards using that file.
- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- From: Christoph Hellwig <[email protected]>
- Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- References:
- [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- From: Roland Dreier <[email protected]>
- Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- From: FUJITA Tomonori <[email protected]>
- Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- From: Roland Dreier <[email protected]>
- Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- From: Christoph Hellwig <[email protected]>
- [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- Prev by Date: Re: <REAL> iBurst (TM) compatible driver
- Next by Date: Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- Previous by thread: Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- Next by thread: Re: [openib-general] Re: [PATCH/RFC] IB: Add SCSI RDMA Protocol (SRP) initiator
- Index(es):
 |