Re: [PATCH 19/20] inflate: (arch) use proper linking

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Mon, Oct 31, 2005 at 03:02:33PM -0800, Matt Mackall wrote:
> On Mon, Oct 31, 2005 at 10:45:01PM +0000, Russell King wrote:
> > On Mon, Oct 31, 2005 at 02:54:52PM -0600, Matt Mackall wrote:
> > > inflate: remove include of lib/inflate.c and use proper linking
> > > 
> > > - make free_mem_ptr vars nonstatic
> > > - make gunzip nonstatic
> > > - add gunzip prototype to new inflate.h
> > > - add per-arch Makefile bits
> > > - change inflate.c includes to inflate.h includes
> > > - change NO_INFLATE_MALLOC to CORE
> > > - compile core kernel version of inflate with -DCORE
> > 
> > We need to build inflate.c with -Dstatic= to disable static data, 
> > and text so that we get the correct binary layout for ARM PIC
> > decompressors.  This patch breaks that.
> 
> So.. we need to add CFLAGS_inflate.o := -Dstatic=? Or is more needed?

I think that'll do.  Trying it in practice will tell though.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/