Re: amd64 bitops fix for -Os

[Pavel Machek <pavel@ucw.cz>]

Hi!

> >> --- arch/x86_64/lib/bitops.c~	2005-10-27 22:02:08.000000000 -0200
> >> +++ arch/x86_64/lib/bitops.c	2005-10-29 18:24:27.000000000 -0200
> >> @@ -1,5 +1,11 @@
> >> #include <linux/bitops.h>
> >> 
> >> +#define BITOPS_CHECK_UNDERFLOW_RANGE 0
> >> +
> >> +#if BITOPS_CHECK_UNDERFLOW_RANGE
> >> +# include <linux/kernel.h>
> >> +#endif
> 
> > Could you drop the ifdefs? Nice for debugging but we don't
> > want them in mainline.
> 
> Are you absolutely sure we don't?  I'd almost left them in, enabled
> unconditionally.  Note that the ifdef will make no difference
> whatsoever for the case I've just fixed, but it would help catch any
> other (ab)uses(?) elsewhere that may have gone unnoticed until now.

Well, ifdefs need to be gone. Maybe you should unconditionally check
it (I do not think so, but...) but ifdefs are certainly wrong.

> > Plus you want to add signed-off-by: header and send it to ak@suse.de.
> 
> Err...  The header was right there.  Or do you mean as an e-mail
> header, as opposed to a regular line in the e-mail body?

Okay, so I'm blind. Sorry. (Yes, it should be in body).

> I'll forward the patch to ak.

Thanks.
								Pavel
-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/