Jordan Crouse wrote:
I'm also concerned about the ammount of protocol awareness in this
driver. Is there a spec available for this hardware? Perhaps the MMC
layer can export more information so that we can avoid switches on
specific MMC commands?
Spec is here:
http://tinyurl.com/dslkv (Horribly long URL and registration required,
unfortunately).
Very nice. First manufacturer I've seen that gives out a spec. without
requiring your soul. :)
In this case, the controller needs to be specifically told what command
and response type it should expect, thus the opcode switch.
I don't really think this is an unreasonable demand to be put on the
hardware driver, and its certainly way more HW specific then the upper
layers need to be.
I've read the spec. and the command response type seems to be the only
thing required. So protocol awareness is acceptable there provided there
is a failure case for any unknown type.
For the command type field the driver should check the number of blocks
and direction, not the command code. SDIO seems more difficult. But
since we do not support that atm we still have the option of making sure
any future implementations consider the needs of this hardware. I doubt
there will be a need for checking command codes here either.
In summary, I see no need for protocol awareness other than response types.
Rgds
Pierre
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
