Re: [RFT/PATCH] atkbd - speed up setting leds/repeat state

On Mon, Oct 31, 2005 at 02:24:02AM -0500, Dmitry Torokhov wrote:
> Input: atkbd - speed up setting leds/repeat state
> 
> Changing led state is pretty slow operation; when there are multiple
> requests coming at a high rate they may interfere with normal typing.
> Try optimize (skip) changing hardware state when multiple requests
> are coming back-to-back.
> 
> Signed-off-by: Dmitry Torokhov <[email protected]>
 
It looks good - just two comments:

	1) wmb() shouldn't be needed after set_bit()

	2) maybe we want to enforce the delay before we send the 
           next SET_LED command.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFT/PATCH] atkbd - speed up setting leds/repeat state
    • From: Dmitry Torokhov <[email protected]>

• References:
  • [RFT/PATCH] atkbd - speed up setting leds/repeat state
    • From: Dmitry Torokhov <[email protected]>

• Prev by Date: Re: [GIT PULL] Tiny input update
• Next by Date: Re: 2.6.14: Oops on suspend after on-the-fly switch to anticipatory i/o scheduler - PowerBook5,4
• Previous by thread: [RFT/PATCH] atkbd - speed up setting leds/repeat state
• Next by thread: Re: [RFT/PATCH] atkbd - speed up setting leds/repeat state
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]