[PATCH] net/core/filter.c, kernel 2.6.14

["Kris Katterjohn" <kjak@ispwest.com>]

Before, the socket filter would apply the filter, then, while running through the steps of the filter on each packet, it would check for division by zero. This patch checks for division by zero (when dividing by a constant) in sk_chk_filter() so the filter won't be applied if a divide-by-zero instruction is found.

This patch is a diff from kernel version 2.6.14.

Signed-off-by: Kris Katterjohn <kjak@users.sourceforge.net>

---

--- x/net/core/filter.c	2005-10-27 19:02:08.000000000 -0500
+++ y/net/core/filter.c	2005-10-30 21:38:41.000000000 -0600
@@ -116,8 +116,6 @@ int sk_run_filter(struct sk_buff *skb, s
 			A /= X;
 			continue;
 		case BPF_ALU|BPF_DIV|BPF_K:
-			if (fentry->k == 0)
-				return 0;
 			A /= fentry->k;
 			continue;
 		case BPF_ALU|BPF_AND|BPF_X:
@@ -320,6 +318,10 @@ int sk_chk_filter(struct sock_filter *fi
 			}
 		}
 
+		/* check for division by zero   -Kris Katterjohn 2005-10-30 */
+		if (ftest->code == (BPF_ALU|BPF_DIV|BPF_K) && ftest->k == 0)
+			return -EINVAL;
+
 		/* check that memory operations use valid addresses. */
 		if (ftest->k >= BPF_MEMWORDS) {
 			/* but it might not be a memory operation... */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/