Hi Olaf, This patch breaks lagacy iSeries i.e. it won't link (iSeries has no get_property()). It may be easier to redo this patch against Paulus' merge tree. A couple of trivial comments: On Sun, 30 Oct 2005 22:39:00 +0100 Olaf Hering <[email protected]> wrote: > > +static int pseries_vio_hotplug (struct device *dev, char **envp, int num_envp, ^ No space here, please. > + length = scnprintf (buffer, buffer_size, "MODALIAS=vio:T%sS%s", ^ No space here either, please. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpentCsQ3f7q.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] ppc64: add MODALIAS= for vio bus
- From: Olaf Hering <[email protected]>
- Re: [PATCH] ppc64: add MODALIAS= for vio bus
- References:
- [PATCH] ppc64: add MODALIAS= for vio bus
- From: Olaf Hering <[email protected]>
- [PATCH] ppc64: add MODALIAS= for vio bus
- Prev by Date: Re: x86_64: 2.6.14 with NUMA panics at boot
- Next by Date: [PATCH][MCAST]IPv6: small fix for ip6_mc_msfilter(...)
- Previous by thread: [PATCH] ppc64: add MODALIAS= for vio bus
- Next by thread: Re: [PATCH] ppc64: add MODALIAS= for vio bus
- Index(es):
 |