Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c

Hi!

> This patch moves the snapshot-handling functions remaining in swsusp.c
> to snapshot.c (ie. it moves the code without changing the functionality).
>

I'm sorry, but I acked this one too quickly. I'd prefer to keep "relocate" code where
it is, and define "must not collide" as a part of interface. That will keep snapshot.c
smaller/simpler, and I plan to
eventually put responsibility for relocation to userspace.

That should simplify error handling at least: data structures
needed for relocation can be kept in userspace memory, and therefore
we do not risk memory leak in case something goes wrong.


				Pavel

-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c
  - From: "Rafael J. Wysocki" <[email protected]>
- Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c
  - From: "Rafael J. Wysocki" <[email protected]>

References:
- [PATCH 0/3] swsusp: code separation continued
  - From: "Rafael J. Wysocki" <[email protected]>
- [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c
  - From: "Rafael J. Wysocki" <[email protected]>

Prev by Date: Re: [patch 0/5] HW RNG cleanup & new drivers
Next by Date: [2.6 patch] fs/xfs/: possible cleanups
Previous by thread: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c
Next by thread: Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]