Re: [PATCH] Disable the most annoying printk in the kernel

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Fri, Oct 28, 2005 at 10:51:32PM +0200, Pavel Machek wrote:
> Well, keyboard detected and reported an error. Kernel reacted with
> printk(). You are removing that printk(). I can understand that,
> printk is really annoying, but I really believe _some_ error handling
> should be added there if you remove the printk.

What do you suggest?

Having a TP 380XD which regularly produces this annoying message,
it's just logspam.  There's no noticable failure.

Plus, kernels previous to ones with the new input subsystem just
used to ignore the scancode (from v2.[24].xx):

int pckbd_translate(unsigned char scancode, unsigned char *keycode,
                    char raw_mode)
{
...
        /* 0xFF is sent by a few keyboards, ignore it. 0x00 is error */
        if (scancode == 0x00 || scancode == 0xff) {
                prev_scancode = 0;
                return 0;
        }
}

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/