Re: [PATCH] Infineon TPM: move infineon driver off pci_dev

Hi Andrew,

> This final return will leak the I/O region from request_region().
> If for some reason the leak is deliberate then a comment is needed.

yep, you're right, I'll fix that

> To reduce the chance of this happening again, please send a followup patch
> which prevents this function from having `return' statements sprinkled all
> over it.  An example would be drivers/net/8139cp.c:cp_init_one(), thanks.

I will send a follow-up patch including the comments of Matthieu.

Thanks for reviewing!

Marcel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Infineon TPM: move infineon driver off pci_dev
    • From: Marcel Selhorst <[email protected]>
  • Re: [PATCH] Infineon TPM: move infineon driver off pci_dev
    • From: matthieu castet <[email protected]>
  • Re: [PATCH] Infineon TPM: move infineon driver off pci_dev
    • From: Marcel Selhorst <[email protected]>
  • Re: [PATCH] Infineon TPM: move infineon driver off pci_dev
    • From: Andrew Morton <[email protected]>

• Prev by Date: NPTL support for 2.4.31?
• Next by Date: Re: NPTL support for 2.4.31?
• Previous by thread: Re: [PATCH] Infineon TPM: move infineon driver off pci_dev
• Next by thread: Re: [PATCH] Infineon TPM: move infineon driver off pci_dev
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]