Re: [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev

On Thu, Oct 27, 2005 at 12:30:09PM -0700, Kristen Accardi wrote:
> --- linux-2.6.13.orig/drivers/pci/probe.c
> +++ linux-2.6.13/drivers/pci/probe.c
> @@ -571,6 +571,7 @@ static void pci_read_irq(struct pci_dev 
>  	unsigned char irq;
>  
>  	pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &irq);
> +	dev->pin = irq;

pci_read_irq() is not called for PCI bridges, but some of them
may need an interrupt (e.g. for shpchp, pciehp). Did you check
if this patchset broke such bridges? You should call this
function for PCI bridges too.

Rajesh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev
    • From: Kristen Accardi <[email protected]>

• References:
  • [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev
    • From: Kristen Accardi <[email protected]>

• Prev by Date: Re: Notifier chains are unsafe
• Next by Date: Re: [patch 1/1] PCI: automatically set device_driver.owner
• Previous by thread: [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev
• Next by thread: Re: [patch 1/3] pci: store PCI_INTERRUPT_PIN in pci_dev
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]