Re: select() for delay.

Hi Maduhu,

On Mon, 2005-10-24 at 16:25 +0530, [email protected] wrote:

> +                        put_user(sec, &tvp->tv_sec);
> +                        put_user(usec, &tvp->tv_usec);

I won't comment on the rest of the patch, but this part is definitely
wrong.  The pointer tvp is a user space address and once you dereference
that pointer to get to tv_sec, you can have a fault, which might
segfault the processes.

What you really want is something like:

{
	timeval tv;

	tv.tv_sec = sec;
	tv.tv_usec = usec;
	copy_to_user(tvp, &tv, sizeof(tv));
}

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: select() for delay.
    • From: Arjan van de Ven <[email protected]>

• References:
  • select() for delay.
    • From: <[email protected]>

• Prev by Date: [PATCH -rc5-mm1] Char, watchdog: remove pci_find_dev
• Next by Date: Re: select() for delay.
• Previous by thread: select() for delay.
• Next by thread: Re: select() for delay.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]