[1/3] [NEIGH] Print stack trace in neigh_add_timer

[NEIGH] Print stack trace in neigh_add_timer

Stack traces are very helpful in determining the exact nature of a bug.
So let's print a stack trace when the timer is added twice.

Signed-off-by: Herbert Xu <[email protected]>
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -732,6 +732,7 @@ static inline void neigh_add_timer(struc
 	if (unlikely(mod_timer(&n->timer, when))) {
 		printk("NEIGH: BUG, double timer add, state is %x\n",
 		       n->nud_state);
+		dump_stack();
 	}
 }
 

---

• References:
  • Re: 2.6.14-rc4-mm1
    • From: Reuben Farrelly <[email protected]>
  • [0/3] Fix timer bugs in neighbour cache
    • From: Herbert Xu <[email protected]>

• Prev by Date: [0/3] Fix timer bugs in neighbour cache
• Next by Date: [2/3] [NEIGH] Fix add_timer race in neigh_add_timer
• Previous by thread: [0/3] Fix timer bugs in neighbour cache
• Next by thread: [2/3] [NEIGH] Fix add_timer race in neigh_add_timer
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]