Re: [patch 5/5] TI OMAP driver

[Tony Lindgren <tony@atomide.com>]

* Tony Lindgren <tony@atomide.com> [051021 21:03]:
> Hi,
> 
> * Tony Lindgren <tony@atomide.com> [051021 19:38]:
> > 
> > Cool, works on OMAP OSK after renaming the function above.
> 
> Looks like the following __iomem patch is needed for this to
> work on OMAP H4.
> 
> At least these two compilers get confused without the following
> patch:
> 
> arm-xscale-linux-gnu-gcc (GCC) 3.4.4
> gcc version 3.4.3 (release) (CodeSourcery ARM Q1B 2005)

Here's one more patch on top of my previous patch. Now it's
tested to work on 24xx too in addition to 16xx. The status
bit did not work on 24xx earlier, and looks like the status
bit is always ready on 16xx.

Tony

--- a/drivers/char/rng/omap-rng.c
+++ b/drivers/char/rng/omap-rng.c
@@ -65,9 +65,10 @@
 	__raw_writel(val, rng_base + reg);
 }
 
+/* REVISIT: Does the status bit really work on 16xx? */
 static int omap_rng_data_present(void)
 {
-	return omap_rng_read_reg(RNG_STAT_REG);
+	return omap_rng_read_reg(RNG_STAT_REG) ? 0 : 1;
 }
 
 static int omap_rng_data_read(u32 *data)