Re: [PATCH 1/4] Swap migration V3: LRU operations

Dave Hansen writes:

[...]

 > 
 > It makes much more sense to have something like:
 > 
 >         if (ret == ISOLATION_IMPOSSIBLE) {
 >         	 list_del(&page->lru);
 >          	 list_add(&page->lru, src);
 >         }
 > 
 > than
 > 
 > +               if (rc == -1) {  /* Not possible to isolate */
 > +                       list_del(&page->lru);
 > +                       list_add(&page->lru, src);
 > +                } if 

And
         if (ret == ISOLATION_IMPOSSIBLE)
          	 list_move(&page->lru, src);

is even better.

Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/4] Swap migration V3: Overview
    • From: Christoph Lameter <[email protected]>
  • [PATCH 1/4] Swap migration V3: LRU operations
    • From: Christoph Lameter <[email protected]>
  • Re: [PATCH 1/4] Swap migration V3: LRU operations
    • From: Dave Hansen <[email protected]>

• Prev by Date: Re: False positive (well not really) on RT backward clock check
• Next by Date: Re: Understanding Linux addr space, malloc, and heap
• Previous by thread: Re: [PATCH 1/4] Swap migration V3: LRU operations
• Next by thread: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]