On Thu, 20 Oct 2005, Ingo Molnar wrote: > > * john stultz <[email protected]> wrote: > > > > > John, would this cause any problems to keep cycle_t at s64? > > > > > > I mean at u64. > > > > Performance would be the only concern. It had been a u64 before I > > started optimizing the code a bit. > > no, this is really a bad optimization that causes unrobustness. > Correctness and robustness comes first. It is so easy to cause a > 500-1000msec delay in the kernel, due to a bad driver or anything. The > timekeeping code should not break like that. > FYI, With rc4-rt13 and changing cycle_t to u64, my machine ran all night without one backward step. Since it use to show up after a couple of hours, I would say that this is the fix. John, Do you want me to take a crack at changing the periodic_hook into using the ktimer code? I understand Ingo's kernel much more than you, but you definitely understand the timing code better than I. Cheers, -- Steve - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: john stultz <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Thomas Gleixner <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- References:
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Steven Rostedt <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Ingo Molnar <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Steven Rostedt <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Ingo Molnar <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Steven Rostedt <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Ingo Molnar <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Steven Rostedt <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Steven Rostedt <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Steven Rostedt <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: john stultz <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- From: Ingo Molnar <[email protected]>
- Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- Prev by Date: Re: [PATCH 0/4] Swap migration V3: Overview
- Next by Date: Re: [PATCH 1/4] Swap migration V3: LRU operations
- Previous by thread: Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- Next by thread: Re: Ktimer / -rt9 (+custom) monotonic_clock going backwards.
- Index(es):