Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.

* Steven Rostedt <[email protected]> wrote:

> On Wed, 19 Oct 2005, Christoph Hellwig wrote:
> 
> > > +	/*
> > > +	 * There's a good chance that the loop will exit in the
> > > +	 * TASK_INTERRUPTIBLE state.
> > > +	 */
> > > +	__set_current_state(TASK_RUNNING);
> >
> > no need to comment the obvious.
> 
> So, should I resend the patch without the comment?

i guess so. OTOH, if it was so obvious, why did it stay unfixed for so 
long ;-)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
    • From: Christoph Hellwig <[email protected]>

• References:
  • scsi_eh / 1394 bug - -rt7
    • From: Mark Knecht <[email protected]>
  • Re: scsi_eh / 1394 bug - -rt7
    • From: Lee Revell <[email protected]>
  • Re: scsi_eh / 1394 bug - -rt7
    • From: Lee Revell <[email protected]>
  • Re: scsi_eh / 1394 bug - -rt7
    • From: Steven Rostedt <[email protected]>
  • [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
    • From: Steven Rostedt <[email protected]>

• Prev by Date: tty line discipline
• Next by Date: Re: [PATCH] ktimers subsystem 2.6.14-rc2-kt5
• Previous by thread: Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
• Next by thread: Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]