Re: What is struct pci_driver.owner for?

Roland Dreier wrote:

I just noticed that at some point, struct pci_driver grew a .owner
member.  However, only a handful of drivers set it:

    $ grep -r -A10 pci_driver drivers/ | grep owner
    drivers/block/sx8.c-    .owner          = THIS_MODULE,
    drivers/ieee1394/pcilynx.c-     .owner =           THIS_MODULE,
    drivers/net/spider_net.c-       .owner          = THIS_MODULE,
    drivers/video/imsttfb.c-        .owner          = THIS_MODULE,
    drivers/video/kyro/fbdev.c-     .owner          = THIS_MODULE,
    drivers/video/tridentfb.c-      .owner  = THIS_MODULE,

Should all drivers be setting .owner = THIS_MODULE?  Is this a good
kernel janitors task?

In theory its for module refcounting. With so many PCI drivers and so few pci_driver::owner users, it makes me wonder how needed it is.

If it is needed (I've done no analysis, even though I am sx8.c author), then it should be applied uniformly.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: What is struct pci_driver.owner for?
    • From: Greg KH <[email protected]>

• References:
  • What is struct pci_driver.owner for?
    • From: Roland Dreier <[email protected]>

• Prev by Date: Re: kernel allows loadkeys to be used by any user, allowing for local root compromise
• Next by Date: [PATCH 2/3 -mm] hpet: use HPET physical addresses for dup. detection
• Previous by thread: What is struct pci_driver.owner for?
• Next by thread: Re: What is struct pci_driver.owner for?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]