On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> Patch looks good. Thanks for the patch.
another 2.6.14 candidate, without it we'd easily get corruption
on shutdown when the root filesystem is on megaraid.
> From: Russell King [mailto:[email protected]]
> Sent: Sunday, October 16, 2005 4:33 PM
> To: Linux Kernel List; Andrew Morton; Greg KH; [email protected]
> Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown method
>
> Convert megaraid to use pci_driver's shutdown method rather than
> the generic device_driver shutdown method.
>
> Signed-off-by: Russell King <[email protected]>
>
> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c
> b/drivers/scsi/megaraid/megaraid_mbox.c
> --- a/drivers/scsi/megaraid/megaraid_mbox.c
> +++ b/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -76,7 +76,7 @@ static void megaraid_exit(void);
>
> static int megaraid_probe_one(struct pci_dev*, const struct pci_device_id
> *);
> static void megaraid_detach_one(struct pci_dev *);
> -static void megaraid_mbox_shutdown(struct device *);
> +static void megaraid_mbox_shutdown(struct pci_dev *);
>
> static int megaraid_io_attach(adapter_t *);
> static void megaraid_io_detach(adapter_t *);
> @@ -369,9 +369,7 @@ static struct pci_driver megaraid_pci_dr
> .id_table = pci_id_table_g,
> .probe = megaraid_probe_one,
> .remove = __devexit_p(megaraid_detach_one),
> - .driver = {
> - .shutdown = megaraid_mbox_shutdown,
> - }
> + .shutdown = megaraid_mbox_shutdown,
> };
>
>
> @@ -673,9 +671,9 @@ megaraid_detach_one(struct pci_dev *pdev
> * Shutdown notification, perform flush cache
> */
> static void
> -megaraid_mbox_shutdown(struct device *device)
> +megaraid_mbox_shutdown(struct pci_dev *pdev)
> {
> - adapter_t *adapter =
> pci_get_drvdata(to_pci_dev(device));
> + adapter_t *adapter = pci_get_drvdata(pdev);
> static int counter;
>
> if (!adapter) {
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
