Re: [PATCH] libata: fix broken Kconfig setup

[Jeff Garzik <jgarzik@pobox.com>]

Matthias Urlichs wrote:

Please use the standard 'group reply' feature of your mailer, to ensure 
that me and other people in the thread are CC'd.


> Hi, Jeff Garzik wrote:
>
>
> > config SCSI_SATA
> > -	tristate "Serial ATA (SATA) support"
> > +	bool "Serial ATA (SATA) support"
> > 	depends on SCSI
>
>
> In other words, if SCSI is false then SCSI_SATA is false too.
>
> So why are you doing
>
>
> > +if SCSI_SATA
> > +
> > config SCSI_SATA_AHCI
> > 	tristate "AHCI SATA support"
> > -	depends on SCSI_SATA && PCI
> > +	depends on SCSI && PCI
>
>
> and not just
>   +     depends on PCI
>
> ?

Because if SCSI==m, then a low-level driver cannot be ==y.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/