Re: [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits

Eric Dumazet <[email protected]> wrote:
>
>  2) The unlock sequence is not anymore inlined. It appears twice or three times 
>  in the kernel.

Is that intentional though?  With <randon .config> my mm/swapfile.i has an
unreferenced

static inline void __raw_spin_unlock(raw_spinlock_t *lock)
{
	__asm__ __volatile__(
		"movb $1,%0" :"=m" (lock->slock) : : "memory" 
	);
}

which either a) shouldn't be there or b) should be referenced.

Ingo, can you confirm that x86's spin_unlock is never inlined?  If so,
what's my __raw_spin_unlock() doing there?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits
    • From: Arjan van de Ven <[email protected]>

• References:
  • i386 spinlock fairness: bizarre test results
    • From: Chuck Ebbert <[email protected]>
  • Re: i386 spinlock fairness: bizarre test results
    • From: Alan Cox <[email protected]>
  • Re: i386 spinlock fairness: bizarre test results
    • From: Linus Torvalds <[email protected]>
  • [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits
    • From: Eric Dumazet <[email protected]>
  • Re: [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits
    • From: Eric Dumazet <[email protected]>

• Prev by Date: Re: 2.6.14-rc4-mm1
• Next by Date: Re: 2.6.14-rc4-mm1
• Previous by thread: Re: [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits
• Next by thread: Re: [PATCH] i386 spinlocks should use the full 32 bits, not only 8 bits
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]