Re: PATCH: EDAC, core EDAC support code

[Doug Thompson <norsk5@yahoo.com>]

--- Arjan van de Ven <arjan@infradead.org> wrote:

> > +
> > +static ctl_table mc_table[] = {
> > +	{-1, "panic_on_ue", &panic_on_ue,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +	{-2, "log_ue", &log_ue,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +	{-3, "log_ce", &log_ce,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +	{-4, "poll_msec", &poll_msec,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +	{-7, "panic_on_pci_parity",
> &panic_on_pci_parity,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +	{-8, "check_pci_parity", &check_pci_parity,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +#ifdef CONFIG_EDAC_DEBUG
> > +	{-9, "debug_level", &edac_debug_level,
> > +	 sizeof(int), 0644, NULL, proc_dointvec},
> > +#endif
> > +	{0}
> > +};
> 
> why aren't these module parameters? Nowadays you can
> have sysfs-runtime
> changable module parameters... sounds a lot nicer
> than adding a chunk of
> sysctl stuff
> 
> > +
> > +#ifdef CONFIG_PROC_FS
> > +static const char *mem_types[] = {
> > +	[MEM_EMPTY] = "Empty",
> > +	[MEM_RESERVED] = "Reserved",
> > +	[MEM_UNKNOWN] = "Unknown",
> > +	[MEM_FPM] = "FPM",
> > +	[MEM_EDO] = "EDO",
> > +	[MEM_BEDO] = "BEDO",
> > +	[MEM_SDR] = "Unbuffered-SDR",
> > +	[MEM_RDR] = "Registered-SDR",
> > +	[MEM_DDR] = "Unbuffered-DDR",
> > +	[MEM_RDDR] = "Registered-DDR",
> > +	[MEM_RMBS] = "RMBS"
> > +};
> 
> 
> why proc? Again this sounds like a platform sysfs
> thing...

The plan is to move from /proc to sysfs operations,
info and control. But the core works at this time and
patches will be forth coming once the baseline is in.
We want to make the currently work features "work".

doug "norsk" thompson



> 
> 
> 
> -
> To unsubscribe from this list: send the line
> "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at 
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 



"If you think Education is expensive, just try Ignorance"

"Don't tell people HOW to do things, tell them WHAT you
want and they will surprise you with their ingenuity."
                   Gen George Patton

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/