Mel wrote:
> +#define __GFP_USER 0x80000u /* User and other easily reclaimed pages */
> +#define __GFP_KERNRCLM 0x100000u /* Kernel page that is reclaimable */
Sorry, but that __GFP_USER name is still sticking in my craw.
I won't try to reopen my quest to get it named __GFP_REALLY_REALLY_EASY_RCLM
or whatever it was, but instead will venture on a new quest.
Can we get the 'RCLM' in there. Especially since this term appears
naked in such code as:
> - page = alloc_page(GFP_HIGHUSER);
> + page = alloc_page(GFP_HIGHUSER|__GFP_USER);
where it is not at all obvious to the reader of this file (fs/exec.c)
that the __GFP_USER term is commenting on the reclaim behaviour of
the page to be allocated.
I'd be happier with:
> +#define __GFP_USERRCLM 0x80000u /* User and other easily reclaimed pages */
> +#define __GFP_KERNRCLM 0x100000u /* Kernel page that is reclaimable */
and:
> - page = alloc_page(GFP_HIGHUSER);
> + page = alloc_page(GFP_HIGHUSER|__GFP_USERRCLM);
Also the bold assymetry of these two #defines seems to be without motivation,
one with the 'RCLM', and the other with ' ' four spaces.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <[email protected]> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
