force feedback envelope incomplete

[emard@softhome.net]

HI

Force feedback envelope struct in input.h 
for periodic events is incomplete.

struct ff_envelope {
        __u16 attack_length;    /* Duration of attack (ms) */
        __u16 attack_level;     /* Level at beginning of attack */
        __u16 fade_length;      /* Duration of fade (ms) */
        __u16 fade_level;       /* Level at end of fade */
};

The envelope consists of:
1. Attack level (Level at beginning of attack)
2. Attack time
3. Sustain level (Level at end of attack and beginning of fade)
4. Sustain time
5. Fade level (Level at the end of fade)
6. Fade time

If I want to implement proper envelope I propose something like this:

struct ff_envelope {
        __u16 attack_length;    /* Duration of attack (ms) */
        __u16 attack_level;     /* Level at beginning of attack */
        __u16 sustain_length;   /* Duration of sustain (ms) */
        __u16 sustain_level;    /* Sustain Level at end of attack and beginning of fade */
        __u16 fade_length;      /* Duration of fade (ms) */
        __u16 fade_level;       /* Level at end of fade */
};
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/