Re: PATCH: EDAC atomic scrub operations

[Avi Kivity <avi@argo.co.il>]

Alan Cox wrote:

> linux-2.6.14-rc2-mm1/include/asm-x86_64/atomic.h
> --- linux.vanilla-2.6.14-rc2-mm1/include/asm-x86_64/atomic.h	2005-09-22 15:22:11.000000000 +0100
> +++ linux-2.6.14-rc2-mm1/include/asm-x86_64/atomic.h	2005-10-14 18:29:47.000000000 +0100
> @@ -378,4 +378,16 @@
> #define smp_mb__before_atomic_inc()	barrier()
> #define smp_mb__after_atomic_inc()	barrier()
>
> +/* ECC atomic, DMA, SMP and interrupt safe scrub function */
> +
> +static __inline__ void atomic_scrub(unsigned long *virt_addr, u32 size)
> +{
> +	u32 i;
> +	for (i = 0; i < size / 4; i++, virt_addr++)
>  
(size+7)  / 8? or increment virt_addr by 0.5? :)

> +		/* Very carefully read and write to memory atomically
> +		 * so we are interrupt, DMA and SMP safe.
> +		 */
> +		__asm__ __volatile__("lock; addl $0, %0"::"m"(*virt_addr));
>  
shouldn't that be addq?

> +}
> +
> #endif
>  

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/