Re: bug in handling of highspeed usb HID devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Also, what device needs this patch?  Is it a device that I can buy
> today?
> 
> thanks,
> 
> greg k-h

The patch is for hid-core.c - I don't think it is device specific - original problem 
should affect all High Speed USB HID devices. 

To summarize -

Current code just looks plain wrong since the same logic is repeated twice - endpoint->bInterval is operated upon twice if the device is HIGH SPEED one.

if (dev->speed == USB_SPEED_HIGH)
                         interval = 1 << (interval - 1);

This is first done in hid-code.c:usb_hid_configure() which then passes interval to  usb.h:usb_fill_int_urb() which again repeats the same logic as above!

Parag



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux