Re: [PATCH ieee80211] fix TX skb allocation flags and size

Michael Buesch wrote:

@@ -221,11 +221,13 @@ static struct ieee80211_txb *ieee80211_a
  txb->frag_size = txb_size;

for (i = 0; i < nr_frags; i++) {

-		txb->fragments[i] = dev_alloc_skb(txb_size);
+		txb->fragments[i] = __dev_alloc_skb(txb_size + headroom,
+						    gfp_mask | GFP_DMA);
 		if (unlikely(!txb->fragments[i])) {
 			i--;

Very wrong.  GFP_DMA means ISA DMA.

See pci_map_xxx() and other DMA API functions.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH ieee80211] fix TX skb allocation flags and size
    • From: Michael Buesch <[email protected]>

• References:
  • [PATCH ieee80211] fix TX skb allocation flags and size
    • From: Michael Buesch <[email protected]>

• Prev by Date: Re: spitz (zaurus sl-c3000) support
• Next by Date: Re: [Security] [vendor-sec] [BUG/PATCH/RFC] Oops while completing async USB via usbdevio
• Previous by thread: [PATCH ieee80211] fix TX skb allocation flags and size
• Next by thread: Re: [PATCH ieee80211] fix TX skb allocation flags and size
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]