Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers

• To: "Miller, Mike (OS Dev)" <[email protected]>
• Subject: Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers
• From: Roland Dreier <[email protected]>
• Date: Thu, 13 Oct 2005 13:12:03 -0700
• Cc: "Jesper Juhl" <[email protected]>, "linux-kernel" <[email protected]>, "Andrew Morton" <[email protected]>, "Len Brown" <[email protected]>, "ISS StorageDev" <[email protected]>, "Jakub Jelinek" <[email protected]>, "Frodo Looijaard" <[email protected]>, "Jean Delvare" <[email protected]>, "Bartlomiej Zolnierkiewicz" <[email protected]>, "Jens Axboe" <[email protected]>, "Roland Dreier" <[email protected]>, "Sergio Rozanski Filho" <[email protected]>, "Benjamin Herrenschmidt" <[email protected]>, "Pierre Ossman" <[email protected]>, "Carsten Gross" <[email protected]>, "Greg Kroah-Hartman" <[email protected]>, "David Hinds" <[email protected]>, "Vinh Truong" <[email protected]>, "Mark Douglas Corner" <[email protected]>, "Michael Downey" <[email protected]>, "Antonino Daplas" <[email protected]>, "Ben Gardner" <[email protected]>
• In-reply-to: <D4CFB69C345C394284E4B78B876C1CF10AF98879@cceexc23.americas.cpqcorp.net> (Mike Miller's message of "Thu, 13 Oct 2005 15:01:42 -0500")
• References: <D4CFB69C345C394284E4B78B876C1CF10AF98879@cceexc23.americas.cpqcorp.net>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (Jumbo Shrimp, linux)

    Mike> I'm not sure I agree that these are pointless
    Mike> checks. They're not in the main code path so nothing is lost
    Mike> by checking first. What if the pointer is NULL????

Read the source to kfree().  The first thing it does is check if the
pointer it is passed is NULL, so the only thing that checking in the
caller does is save a function call.  However I agree with Jesper that
saving .text and cutting down on source code size far outweighs the
cost of these extra function calls.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • RE: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers
    • From: "Miller, Mike (OS Dev)" <[email protected]>

• Prev by Date: Re: sched_clock -> check_tsc_unstable -> tsc_read_c3_time ?!?
• Next by Date: Re: sched_clock -> check_tsc_unstable -> tsc_read_c3_time ?!?
• Previous by thread: Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers
• Next by thread: Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]