Re: sys_sendfile oops in 2.6.13?

[Grzegorz Nosek <grzegorz.nosek@gmail.com>]

2005/10/12, Chris Wright <chrisw@osdl.org>:
> * Grzegorz Nosek (grzegorz.nosek@gmail.com) wrote:
> > --- linux-2.6/fs/read_write.c~  2005-10-06 21:35:03.000000000 +0200
> > +++ linux-2.6/fs/read_write.c   2005-10-05 19:14:04.000000000 +0200
> > @@ -719,7 +719,7 @@
> >        current->syscr++;
> >        current->syscw++;
> >
> > -       if (*ppos > max)
> > +       if (ppos && *ppos > max)
> >                retval = -EOVERFLOW;
>
> This doesn't make sense.  ppos must not be NULL.
>
> Code looks like this:
>
> if (!ppos)
>          ppos = &in_file->f_pos;
> ...
> pos = *ppos;
> ...
> if (*ppos > max)
>
> So it can't be NULL, and if somehow it were, the oops would've already
> happened.
>

Yeah, I know. It turned out to be a 3rd-party patch (vserver
probably). My read_write.c looks very different and somehow I
overlooked that while checking with vanilla 2.6.13.3. Sorry for the
confusion.

Regards,
 Greg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/