This patch removes the list_head member 'list' from struct tcx_par in
the file drivers/video/tcx.c among other trivial cleanups. The member
'list' is never used. It turns out that other frame buffer code like
cg14.c, leo.c, bw2.c, etc. (in drivers/video) seem to have the same
extra list_head member in their respective *_par structures.
The patch applies to the 2.6.13.4 kernel sources.
(AFAICT, I am not missing anything; If I am, I'm sorry for wasting your
time.)
Thanks,
Hareesh Nagarajan
--- linux-2.6.13.4/drivers/video/tcx.c 2005-10-10 13:54:29.000000000 -0500
+++ linux-2.6.13.4-edit/drivers/video/tcx.c 2005-10-10 21:05:22.110156000 -0500
@@ -123,7 +123,6 @@
int lowdepth;
struct sbus_dev *sdev;
- struct list_head list;
};
/* Reset control plane so that WID is 8-bit plane. */
@@ -174,13 +173,13 @@
unsigned red, unsigned green, unsigned blue,
unsigned transp, struct fb_info *info)
{
+ if (regno >= 256)
+ return 1;
+
struct tcx_par *par = (struct tcx_par *) info->par;
struct bt_regs __iomem *bt = par->bt;
unsigned long flags;
- if (regno >= 256)
- return 1;
-
red >>= 8;
green >>= 8;
blue >>= 8;
@@ -442,7 +441,7 @@
tcx_reset(&all->info);
- tcx_blank(0, &all->info);
+ tcx_blank(FB_BLANK_UNBLANK, &all->info);
if (fb_alloc_cmap(&all->info.cmap, 256, 0)) {
printk(KERN_ERR "tcx: Could not allocate color map.\n");
@@ -490,8 +489,7 @@
struct list_head *pos, *tmp;
list_for_each_safe(pos, tmp, &tcx_list) {
- struct all_info *all = list_entry(pos, typeof(*all), list);
-
+ struct all_info *all = list_entry(pos, struct all_info, list);
unregister_framebuffer(&all->info);
fb_dealloc_cmap(&all->info.cmap);
kfree(all);
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
