Hi Kristen,
At Fri, 07 Oct 2005 10:45:46 -0700,
Kristen Accardi <[email protected]> wrote:
>
> Allocate resources for adapters with p2p bridges.
>
> Signed-off-by: Kristen Carlson Accardi <[email protected]>
>
> diff -uprN -X linux-2.6.14-rc2/Documentation/dontdiff linux-2.6.14-rc2/drivers/pci/hotplug/acpiphp_glue.c linux-2.6.14-rc2-kca1/drivers/pci/hotplug/acpiphp_glue.c
> --- linux-2.6.14-rc2/drivers/pci/hotplug/acpiphp_glue.c 2005-08-28 16:41:01.000000000 -0700
> +++ linux-2.6.14-rc2-kca1/drivers/pci/hotplug/acpiphp_glue.c 2005-09-28 10:43:15.000000000 -0700
> @@ -58,6 +58,9 @@ static LIST_HEAD(bridge_list);
>
> static void handle_hotplug_event_bridge (acpi_handle, u32, void *);
> static void handle_hotplug_event_func (acpi_handle, u32, void *);
> +static void acpiphp_sanitize_bus(struct pci_bus *bus);
> +static void acpiphp_set_hpp_values(acpi_handle handle, struct pci_bus *bus);
> +
>
> /*
> * initialization & terminatation routines
> @@ -207,6 +210,9 @@ register_slot(acpi_handle handle, u32 lv
> slot->flags |= (SLOT_ENABLED | SLOT_POWEREDON);
> }
>
> + /* store the handle in the slot for later. */
> + slot->handle = handle;
> +
> /* install notify handler */
> status = acpi_install_notify_handler(handle,
> ACPI_SYSTEM_NOTIFY,
> @@ -796,7 +802,12 @@ static int enable_device(struct acpiphp_
> }
> }
>
> + pci_bus_size_bridges(bus);
> pci_bus_assign_resources(bus);
> + acpiphp_sanitize_bus(bus);
> + acpiphp_set_hpp_values(slot->handle, bus);
> + pci_enable_bridges(bus);
> + acpiphp_configure_ioapics(slot->handle);
> pci_bus_add_devices(bus);
>
> /* associate pci_dev to our representation */
> diff -uprN -X linux-2.6.14-rc2/Documentation/dontdiff linux-2.6.14-rc2/drivers/pci/hotplug/acpiphp.h linux-2.6.14-rc2-kca1/drivers/pci/hotplug/acpiphp.h
> --- linux-2.6.14-rc2/drivers/pci/hotplug/acpiphp.h 2005-08-28 16:41:01.000000000 -0700
> +++ linux-2.6.14-rc2-kca1/drivers/pci/hotplug/acpiphp.h 2005-09-28 10:43:15.000000000 -0700
> @@ -119,6 +119,7 @@ struct acpiphp_slot {
> struct list_head funcs; /* one slot may have different
> objects (i.e. for each function) */
> struct semaphore crit_sect;
> + acpi_handle handle;
>
> u32 id; /* slot id (serial #) for hotplug core */
> u8 device; /* pci device# */
If the p2p bridge is one of the multi-function devices,
the slot->handle would be over-written by the last found
device's handle.
Is your adaptor is *non*-multifunctional?
I'm also working for p2p hotplug with acpiphp, and your code
is almost same to mine. I could find some bugs in my patch
by your patch. I'll update my patch.
Thanks,
MUNE
--
MUNEDA Takahiro <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
