Re: [RFC] gfp flags annotations - part 6 (simple parts of fs/*)

Al Viro writes:
 > 	A bug had been caught in relayfs code -
 >         mem = vmap(buf->page_array, n_pages, GFP_KERNEL, PAGE_KERNEL);
 > in fs/relayfs/buffers.c is bogus (the third argument of vmap() is unrelated
 > to gfp flags).  s/GFP_KERNEL/VM_MAP/, presumably?  Author Cc'd, code in
 > question left alone for now.
 > 

Yes, looks like a stupid typo that luckily wasn't affecting the
outcome because the GFP_KERNEL value happens to not cause any false
test outcomes in the vmap code.  I'll submit a patch momentarily.

Thanks for catching this.

Tom



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCHSET] 2.6.14-rc3-git4-bird1
    • From: Al Viro <[email protected]>
  • Re: [PATCHSET] 2.6.14-rc3-git4-bird1
    • From: Alexey Dobriyan <[email protected]>
  • [RFC] gfp flags annotations
    • From: Al Viro <[email protected]>
  • Re: [RFC] gfp flags annotations
    • From: Linus Torvalds <[email protected]>
  • [RFC] gfp flags annotations - part 6 (simple parts of fs/*)
    • From: Al Viro <[email protected]>

• Prev by Date: [PATCH] relayfs: fix bogus param value in call to vmap
• Next by Date: [PATCH] coredump_wait() cleanup
• Previous by thread: [RFC] gfp flags annotations - part 6 (simple parts of fs/*)
• Next by thread: [RFC] gfp flags annotations - part 7 (block layer)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]