Re: [patch 3/4] new serial flow control

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Hi,

Russell King, le Sun 09 Oct 2005 12:17:18 +0100, a écrit :
> On Sun, Oct 09, 2005 at 12:09:09PM +0200, Samuel Thibault wrote:
> > - some other use it as a strobe for acknowledging characters, some other
> > use it as a strobe for acknowledging frames (announced by CTS).
> 
> The last has no business being in the serial driver though -
> the driver knows nothing about frames of characters.  It's more
> a userland (in which case it's TIOCM* ioctls) or ldisc issue
> (tty_driver->tiocmset).

In principle, yes. But implementing it in userland is not responsive
enough doesn't work reliably, while it can actually be implemented in
the serial driver as "acknowledge any CTS upfront" (if the device is not
throttled), and then it works fine. Writing a whole line discipline (and
getting it accepted in the kernel) just for this is a bit overkill.

> > > However, bear in mind that the majority of the more inteligent 8250-
> > > compatible UARTs with large FIFOs only do hardware flow control on
> > > RTS/CTS
> > 
> > Hardward flow control is usually performed in software. Can't their
> > hardware implementation of hardware flow control be disabled when
> > control method is not usual RTS/CTS?
> 
> You missed the point.  Of course the hardware flow control can be
> disabled.  However, if you do have on-chip CTS flow control disabled
> with UARTs with large FIFOs,
> etc..

Yes, of course. But can't this be disabled too? (people won't mind cpu
overhead if they can at least get their device working).

Regards,
Samuel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/