Re: [RFC] Hard disk protection revisited

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jens Axboe wrote:

I have to nack this one for now, I still want the generic command types
patch to go in first. We have far too many queue hooks already, adding
two more for a relatively obscure use such as this one is not a good
idea.

My suggestion is to maintain this patch out of tree for now, it will be
a few kernel release iterations before the command type patch is in.

That's a fair comment (and not entirely unexpected), I don't have a problem with looking after this out of tree for now...

One issue with the generic command approach occured to me while making this patch - although it's more likely an issue with my understanding ;)

I'm assuming that it would work like this -- the block layer still has the sysfs attribute, and queues the new command for the lower driver to pick up. The driver receives the command and does it's custom park/freeze work, then calls a common block layer function to setup the timer (all good so far). Where it gets hazy (for me) is how the block layer starts the queue up again - as this ended up needing to be driver specific & I can't see how the block layer would get another command down if the queue is stopped?

Regards,
Jon.




______________________________________________________________
Email via Mailtraq4Free from Enstar (www.mailtraqdirect.co.uk)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux