Re: Fwd: Telecom Clock Driver for MPCBL0010 ATCA computer blade

[Alexey Dobriyan <adobriyan@gmail.com>]

> Attached is an update that I think addresses your other comments.

> +config TELCLOCK
> +	tristate "Telecom clock driver for ATCA"
> +	depends on EXPERIMENTAL
> +	default n
> +	help
> +	  The telecom clock device allows direct userspace access to the
> +	  configuration of the telecom clock configuration settings.
> +	  This device is used for hardware synchronization across the ATCA
> +	  backplane fabric.

People usually tell here how the module will be called. See plenty
examples around.

> --- linux-2.6.14-rc2-mm2/drivers/char/tlclk.c
> +++ linux-2.6.14-rc2-mm2-tlclk/drivers/char/tlclk.c
> +Uppon loading the driver will create a sysfs directory under class/misc/tlclk.

Upon.

> +static int __init tlclk_init(void)
> +{

Missing unregister_chrdev() on error unrolling.

> +		printk(KERN_ERR" misc_register retruns %d\n", ret);

returns.

> +	return 0;
> +out3:
> +	release_region(TLCLK_BASE, 8);
> +out2:
> +	kfree(alarm_events);
> +out1:
> +	return ret;
> +}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/