On 10/6/05, Arthur Othieno <[email protected]> wrote:
> On Wed, Oct 05, 2005 at 11:56:49PM +0200, Jesper Juhl wrote:
> > Small CodingStyle cleanup for kernel/printk.c
> > Removes some trailing whitespace
> > Breaks long lines and make other small changes to conform to CodingStyle
> > Add explicit printk loglevels in two places.
> >
> > Linus: Sorry to Cc: you on something as trivial as this, but you /are/ listed as
> > the author of the file and I couldn't find a relevant maintainer (except for
> > perhaps Andrew (so I added him to CC as well)).
> >
> >
> > Signed-off-by: Jesper Juhl <[email protected]>
> > ---
> >
> > Patch has been compile tested.
> >
> > kernel/printk.c | 78 ++++++++++++++++++++++++++++++--------------------------
> > 1 files changed, 42 insertions(+), 36 deletions(-)
> >
> > --- linux-2.6.14-rc3-git5-orig/kernel/printk.c 2005-10-03 21:55:39.000000000 +0200
> > +++ linux-2.6.14-rc3-git5/kernel/printk.c 2005-10-05 23:46:54.000000000 +0200
> > @@ -169,11 +169,11 @@ static int __init log_buf_len_setup(char
> > size = roundup_pow_of_two(size);
> > if (size > log_buf_len) {
> > unsigned long start, dest_idx, offset;
> > - char * new_log_buf;
> > + char *new_log_buf;
> >
> > new_log_buf = alloc_bootmem(size);
> > if (!new_log_buf) {
> > - printk("log_buf_len: allocation failed\n");
> > + printk(KERN_WARNING "log_buf_len: allocation failed\n");
>
> Wouldn't KERN_ERR be more appropriate here?
I don't think so. Things will still work.
Personally I consider this a warning condition, and without an
explicit loglevel that's also what it was logged as in the past, so
this changes nothing.
If other people disagree I can modify the patch, sure, but I think
KERN_WARNING is appropriate.
[snip]
> > - struct console *a,*b;
> > + struct console *a, *b;
> > int res = 1;
>
> Beep! :)
>
huh?
--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
