Re: [patch 08/28] Input: prepare to sysfs integration

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On 10/5/05, Greg KH <gregkh@suse.de> wrote:
> On Thu, Sep 15, 2005 at 02:01:39AM -0500, Dmitry Torokhov wrote:
> > Input: prepare to sysfs integration
> >
> > Add struct class_device to input_dev; add input_allocate_dev()
> > to dynamically allocate input devices; dynamically allocated
> > devices are automatically registered with sysfs.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
>
> Ok, I've applied this one, and the other "convert the input drivers to
> be dynamic" to my tree, as this is all great work.
>
> I'll work on the last few patches that you have, with regard to how to
> tie it into sysfs "properly" now, and get back to you, just wanted to
> apply all of these, so we have a common base to work on.
>

Greg,

Could you please drop these patches for a while? Or maybe just don't
push them to Linus yet. The reason is that I want to change
input_allocate_device to take bitmap of supported events. This way I
could allocate ABS tables dynamically at the same time I allocate
input_dev itself and it will simplify error handling logic in drivers
and it will save I think 1260 bytes per input_dev structure which is
nice. And I don't want to go through all subsystems yet again soI want
to fold into my input dynalloc patch...

> Oh, I did change one thing in this patch:
>
> >
> > +EXPORT_SYMBOL(input_allocate_device);
>
> I made that EXPORT_SYMBOL_GPL().  Let me know if you object to this.
>

That's fine with me.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/